lukecwik commented on pull request #15113: URL: https://github.com/apache/beam/pull/15113#issuecomment-872512044
> > netty uses log4j and commons-logging and is a transitive dep of grpc. > > From your comment in https://issues.apache.org/jira/browse/BEAM-12422 > > Can you give me the Maven coordinates of the netty library you checked? > > I tried generating the dependency tree (https://gist.github.com/suztomo/5b906fa4850b4685081e870d45ae26b9) of `vendor/grpc-1_36_0` but I don't find them. https://mvnrepository.com/artifact/io.netty/netty-common/4.1.52.Final I looked at the source and it seems as though they try a bunch of loggers to find which one exists https://github.com/netty/netty/blob/5178b2c7a5eb876f06912753e8251836bc3f1051/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java so we could close this PR and leave your change as is. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
