lostluck commented on a change in pull request #15057: URL: https://github.com/apache/beam/pull/15057#discussion_r662660744
########## File path: sdks/go/examples/snippets/04transforms.go ########## @@ -0,0 +1,289 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package snippets + +import ( + "fmt" + "math" + "reflect" + "sort" + "strings" + + "github.com/apache/beam/sdks/go/pkg/beam" + "github.com/apache/beam/sdks/go/pkg/beam/transforms/stats" +) + +// [START model_pardo_pardo] + +// ComputeWordLengthFn is the DoFn to perform on each element in the input PCollection. +type ComputeWordLengthFn struct{} + +// ProcessElement is the method to execute for each element. +func (fn *ComputeWordLengthFn) ProcessElement(word string, emit func(int)) { Review comment: It mostly comes down to if a user only learns the return convenience, they're stuck with 1:1. If they learn emitters, they can build off of that for 0 to 1, and multiple output PCollections by themselves. With the return convenience, it needs to be explained that it's always the first output PCollection, in the case the return and the emitter are mixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
