tysonjh commented on pull request #15080:
URL: https://github.com/apache/beam/pull/15080#issuecomment-873291623


   > Hm... The precommit is failing on the spotbugs check:
   > 
   > ```
   > 19:47:04 Execution failed for task ':sdks:java:harness:spotbugsMain'.
   > 19:47:04 > A failure occurred while executing 
com.github.spotbugs.snom.internal.SpotBugsRunnerForWorker$SpotBugsExecutor
   > ```
   
   Spotbugs is hitting a false positive here, the call is clearly synchronized, 
so we can go ahead with this change:
   
   In class 
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor
   Field 
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId
   Synchronized 66% of the time
   Unsynchronized access at ProcessBundleHandler.java:[line 752]
   Synchronized access at ProcessBundleHandler.java:[line 748]
   Synchronized access at ProcessBundleHandler.java:[line 744]
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to