chamikaramj commented on a change in pull request #15090:
URL: https://github.com/apache/beam/pull/15090#discussion_r665664496
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -838,6 +850,16 @@ public void setTimestampPolicy(String timestampPolicy) {
}
}
+ /**
+ * Sets nullKeyFlag for present of null keys
+ *
+ * <p>By default, nullKeyFlag is {@code false} and will invoke {@link
KafkaRecordCoder} when
+ * nullKeyFlag is {@code true}, it invokes {@link
NullableKeyKafkaRecordCoder}
+ */
+ public Read<K, V> withNullKeyFlag() {
Review comment:
Makes sense. Probably consider renaming this to something like
"withSupportsNullKeys()" and update documentation to describe usability instead
of implementation details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
