veblush commented on a change in pull request #14817:
URL: https://github.com/apache/beam/pull/14817#discussion_r665769781
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
##########
@@ -400,6 +402,22 @@ public SeekableByteChannel open(GcsPath path) throws
IOException {
return googleCloudStorage.open(new StorageResourceId(path.getBucket(),
path.getObject()));
}
+ /**
+ * Opens an object in GCS.
+ *
+ * <p>Returns a SeekableByteChannel that provides access to data in the
bucket.
+ *
+ * @param path the GCS filename to read from
+ * @param readOptions Fine-grained options for behaviors of retries,
buffering, etc.
+ * @return a SeekableByteChannel that can read the object data
+ */
+ @VisibleForTesting
+ SeekableByteChannel open(GcsPath path, GoogleCloudStorageReadOptions
readOptions)
Review comment:
This is used for the test. Previously test access the implementation
detail (e.g. `GoogleCloudStorageReadChannel`) in
`testGCSChannelCloseIdempotent()` but it doesn't need to do it anymore with
this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
