AlikRodriguez commented on a change in pull request #15118:
URL: https://github.com/apache/beam/pull/15118#discussion_r667024903
##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py
##########
@@ -463,14 +463,13 @@ def test_clear(self):
recording.wait_until_finish()
# Assert that clearing only one recording clears that recording.
- self.assertGreater(rm_1.describe()['size'], 0)
- self.assertGreater(rm_2.describe()['size'], 0)
- rm_1.clear()
- self.assertEqual(rm_1.describe()['size'], 0)
- self.assertGreater(rm_2.describe()['size'], 0)
-
- rm_2.clear()
- self.assertEqual(rm_2.describe()['size'], 0)
+ if rm_1.describe()['size'] > 0 and rm_2.describe()['size'] > 0:
Review comment:
You are right, I change it. As I can see, it's not really a problem but
an expected behavior in some scenarios. There is actually a flag that indicates
when the record stopped, and it can happen when it is not necessary to record
the same data twice.
I added another test for check single clear in one record and test this
case apart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
