ibzib commented on a change in pull request #15105:
URL: https://github.com/apache/beam/pull/15105#discussion_r667152661
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -569,12 +586,17 @@ def _create_extra_packages(extra_packages, temp_dir):
if not os.path.isfile(package):
if Stager._is_remote_path(package):
- # Download remote package.
- _LOGGER.info(
- 'Downloading extra package: %s locally before staging', package)
- _, last_component = FileSystems.split(package)
- local_file_path = FileSystems.join(staging_temp_dir, last_component)
- Stager._download_file(package, local_file_path)
+ if Stager._should_download_remote_extra_packages(package):
+ # Download remote package.
+ _LOGGER.info(
+ 'Downloading extra package: %s locally before staging',
package)
+ _, last_component = FileSystems.split(package)
+ local_file_path = FileSystems.join(staging_temp_dir,
last_component)
+ Stager._download_file(package, local_file_path)
+ else:
+ remote_packages.append(package)
+ _LOGGER.info(
+ 'Deferring download of extra package: %s to workers', package)
Review comment:
The text of CHANGES.md eventually makes its way into the release notes,
so that should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
