je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r667308702
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +515,19 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
.build();
}
+ protected Pipeline createPipeline() {
+ PipelineOptions effectiveOpts = PipelineOptionsFactory.create();
Review comment:
I created new PipelineOptions per expansion and copy the important
options from the command-line. On the other hand I think, that from user
perspective this has very low difference, because the main issue here is that
the user (with good intentions) specifies an option that is not supported by
the service (e.g. most obviously the `runner`). The command line will accept
it, but it will be simply silently ignored. I think that is the case we need to
address by the validation scope annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
