je-ik commented on a change in pull request #15159:
URL: https://github.com/apache/beam/pull/15159#discussion_r668504324
##########
File path:
sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
##########
@@ -132,6 +132,9 @@
</filters>
<transformers>
<transformer
implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>reference.conf</resource>
Review comment:
Flink uses [akka](https://akka.io/), which in turn uses [typesafe
config](https://github.com/lightbend/config) for configuration. The typesafe
config uses two types of configuration files - `reference.conf` and
`application.conf`, where the first holds defaults which the latter can
(optionally) override. Both these files are located in resources of respective
jar (library). Akka has several modules, each of which has its own
`reference.conf`, which is fine as long as each of these jars is on classpath.
When we shade them together, we must append the respective `reference.conf`s so
that every default value of each (sub)module has a default value.
https://doc.akka.io/docs/akka/current/additional/packaging.html#maven-jarjar-onejar-or-assembly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
