WeiwenXu21 commented on a change in pull request #15090:
URL: https://github.com/apache/beam/pull/15090#discussion_r670794094
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -847,6 +858,18 @@ public void setTimestampPolicy(String timestampPolicy) {
}
}
+ /**
+ * Update SupportsNullKeys for present of null keys
+ *
+ * <p>By default, withSupportsNullKeys is {@code false} and will invoke
{@link KafkaRecordCoder}
+ * as normal. In this case, {@link KafkaRecordCoder} will not be able to
handle null keys.
+ * When nullKeyFlag is {@code true}, it wraps the key coder with a {@link
NullableCoder} before
+ * invoking {@link KafkaRecordCoder}. In this case, it can handle null
keys.
+ */
+ public Read<K, V> withSupportsNullKeys() {
Review comment:
Do you mean use `withNullabeKeys ` as method name instead of
`withSupportsNullKeys `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
