jrmccluskey commented on a change in pull request #15175:
URL: https://github.com/apache/beam/pull/15175#discussion_r671334420
##########
File path: sdks/go/pkg/beam/testing/passert/floats.go
##########
@@ -26,6 +26,56 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
+// EqualsFloat checks that two PCollections of floats are equal, with each
element
+// being within a specified threshold of its corresponding element. Both
PCollections
+// are loaded into memory, sorted, and compared element by element.
+func EqualsFloat(s beam.Scope, observed, expected beam.PCollection, threshold
float64) {
Review comment:
Added the validation (and split out into a helper since AllWithinBounds
did the same thing anyway.)
Is there a reference for splitting a DoFn into that Try function? I haven't
been able to find another example of that design pattern in the SDK and I'm not
seeing any examples of pulling the errors out of the ParDo0 call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
