nehsyc commented on pull request #15178: URL: https://github.com/apache/beam/pull/15178#issuecomment-881637699
> Do you think we should keep the old behavior as an option in case some customers run into issues ? The override was not used because before the introduction of auto sharding, streaming write was required to specify a fixed number of shards otherwise fails: https://github.com/apache/beam/blob/d7eb872576c89abba299ed445075ff593ff556a5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java#L319 I forgot to remove the override when I loosed the check to allow runner determined sharding for unbounded data :\ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
