lukecwik commented on a change in pull request #15137:
URL: https://github.com/apache/beam/pull/15137#discussion_r672652975
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -939,6 +939,31 @@ message StandardCoders {
// Experimental.
STATE_BACKED_ITERABLE = 9 [(beam_urn) =
"beam:coder:state_backed_iterable:v1"];
+
+ // Encodes an arbitrary user defined window and its max timestamp
(inclusive).
+ // The encoding format is:
+ // maxTimestamp window
+ //
+ // maxTimestamp - A big endian 8 byte integer representing
millis-since-epoch.
+ // The encoded representation is shifted so that the byte
representation
+ // of negative values are lexicographically ordered before the byte
+ // representation of positive values. This is typically done by
Review comment:
I suggested copying it verbatim as that is the text in those segments
already.
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -939,6 +939,31 @@ message StandardCoders {
// Experimental.
STATE_BACKED_ITERABLE = 9 [(beam_urn) =
"beam:coder:state_backed_iterable:v1"];
+
+ // Encodes an arbitrary user defined window and its max timestamp
(inclusive).
+ // The encoding format is:
+ // maxTimestamp window
Review comment:
I would rather have the length prefix to be a component as Yichi
describes since this will allow other length prefixing schemes then the current
one we have.
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/CloudObjectKinds.java
##########
@@ -21,6 +21,7 @@
class CloudObjectKinds {
static final String KIND_GLOBAL_WINDOW = "kind:global_window";
static final String KIND_INTERVAL_WINDOW = "kind:interval_window";
+ static final String KIND_CUSTOM_WINDOW = "kind:custom_window";
Review comment:
It isn't needed since we shouldn't need to pass these in anymore to
Dataflow since the beam proto -> DFE conversion should happen internally but I
didn't ask to remove it since it was already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
