fernando-wizeline commented on pull request #15039:
URL: https://github.com/apache/beam/pull/15039#issuecomment-882685982


   > Any updates on this PR?
   
   Hi Tyson!
   This is ready for review. If no further suggestions are made, I'd say it is 
ready for merging; but, since the DB connection information is now being picked 
up from the OS (Dockerized or otherwise), the step that saves the status of the 
jobs will fail.
   If we want to decouple this from the runners migration to GKE, I'd say we 
should, for the moment, get the DB connection info from GitHub secrets and once 
the migration to GKE is completed we can switch back to obtaining the DB info 
from the OS.
   What are your thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to