youngoli commented on a change in pull request #15186:
URL: https://github.com/apache/beam/pull/15186#discussion_r673382060
##########
File path: sdks/go/pkg/beam/core/runtime/exec/sdf_test.go
##########
@@ -925,3 +1083,105 @@ func (rt *SplittableUnitRTracker) TrySplit(_ float64)
(interface{}, interface{},
func (rt *SplittableUnitRTracker) GetProgress() (float64, float64) {
return rt.Done, rt.Remaining
}
+
+// TestMultiWindowProcessing tests that ProcessSizedElementsAndRestrictions
+// handles processing multiple windows correctly, even when progress is
+// reported and splits are performed during processing.
+func TestSplittingValidationProcessing(t *testing.T) {
Review comment:
This function looks like just a copy of TestMultiWindowProcessing. I'm
guessing you were going to modify it to test the invalid split size and either
forgot or changed your mind?
Regardless, I think the tests you currently have provide enough coverage, so
you should remove this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
