rohdesamuel commented on a change in pull request #15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r678652330
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3392,7 +3395,7 @@ def melt(self, ignore_index, **kwargs):
@frame_base.with_docs_from(pd.DataFrame)
def value_counts(self, subset=None, sort=False, normalize=False,
- ascending=False):
+ ascending=False, dropna=True):
Review comment:
Ah I understand now. We keep dropna=True here to keep backwards
compatibility with Pandas version < 1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
