emkornfield commented on a change in pull request #15185:
URL: https://github.com/apache/beam/pull/15185#discussion_r679439973
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -883,6 +890,184 @@ def _export_files(self, bq):
return table.schema, metadata_list
+class _CustomBigQueryStorageStreamSourceBase(BoundedSource):
+ """A base class for BoundedSource implementations which read from BigQuery
+ using the BigQuery Storage API."""
+ def __init__(
+ self,
+ project=None,
Review comment:
if dataset and table are required it might make sense to move them up
and not let them default to None to better document they are required.
Not sure of Beam's policies but you might want to use type annotations or
documented expected types of each parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
