ibzib commented on pull request #15244: URL: https://github.com/apache/beam/pull/15244#issuecomment-890235052
I wonder if we should keep some of the UDF methods experimental. There are currently three `registerUdf` methods and we might introduce a fourth eventually for [ScalarFn](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/udf/src/main/java/org/apache/beam/sdk/extensions/sql/udf/ScalarFn.java). And `registerUdaf` has always been a little sketchy since SQL UDAFs ignore many of the methods of `CombineFn`. Otherwise LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
