PawasChhokra commented on a change in pull request #14945:
URL: https://github.com/apache/beam/pull/14945#discussion_r681215325
##########
File path: runners/samza/src/test/resources/ExpectedDag.json
##########
@@ -0,0 +1,103 @@
+{
+ "RootNode": [
+ { "fullName":"OuterMostNode",
+ "shortName":"OuterMostNode",
+ "id":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues",
+ "shortName":"Create.TimestampedValues",
+ "id":"Create.TimestampedValues",
+ "enclosingNode":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues/Create.Values",
+ "shortName":"Create.Values",
+ "id":"Create.TimestampedValues/Create.Values",
+ "enclosingNode":"Create.TimestampedValues",
+ "ChildNode":[
+ {
"fullName":"Create.TimestampedValues/Create.Values/Read(CreateSource)",
+ "shortName":"Read(CreateSource)",
Review comment:
Looked at how this works under the hood and the `fullName` for a node is
derived from the parent node's `fullName` plus the current transform's
`getName()` method itself. Hence, I'll remove the `shortName` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
