reuvenlax commented on a change in pull request #15249:
URL: https://github.com/apache/beam/pull/15249#discussion_r684340809



##########
File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -340,6 +342,16 @@ public long getElementByteSize() {
     @StateId(NUM_BYTES_IN_BATCH_ID)
     private final StateSpec<CombiningState<Long, long[], Long>> 
batchSizeBytesSpec;
 
+    private static final String TIMER_TIMESTAMP = "timerTs";
+
+    @StateId(TIMER_TIMESTAMP)
+    private final StateSpec<ValueState<Long>> timerTsSpec;

Review comment:
       Done

##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java
##########
@@ -100,9 +100,9 @@
   Timer withOutputTimestamp(Instant outputTime);
 
   /**
-   * Returns the current relative time used by {@link #setRelative()} and 
{@link #offset}. This can
-   * be used by a client that self-manages relative timers (e.g. one that 
stores the current timer
-   * time in a state variable.
+   * * Returns the current relative time used by {@link #setRelative()} and 
{@link #offset}. This
+   * can be used by a client that self-manages relative timers (e.g. one that 
stores the current

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to