MiguelAnzoWizeline commented on pull request #14811: URL: https://github.com/apache/beam/pull/14811#issuecomment-894481467
Hi @chamikaramj thanks for the reply. The idea that you mention of a single SDF that combines "GeneratePartitionsFn" and "ReadFromPartitionFn" with the logic of "GeneratePartitionsFn" pushed into "splitRestriction" was initially attempted, but it required for the SideInput to be accessible in "splitRestriction" which is not possible and an issue was raised https://issues.apache.org/jira/browse/BEAM-12522 earlier in this PR, which is the main reason we were wondering if there is a point to continue right now, or wait until BEAM-12522 is done and we can go for the single SDF approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
