lukecwik commented on pull request #15300: URL: https://github.com/apache/beam/pull/15300#issuecomment-895588554
> This is an initial implementation that reads max memory from a cgroup file (note: this does affect current tests such as RemoteExecution tests that are not containerized) > > Rui suggested using a hard coded cap vs a percentage like the legacy worker which defaulted to 100mb - wondering what your thoughts are @lukecwik Using a hard-coded cap was a mistake as it didn't scale with machine size and in many cases we needed to tell users to specify a flag. Also a percent will likely work better with future VM right sizing work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
