InigoSJ commented on pull request #15126: URL: https://github.com/apache/beam/pull/15126#issuecomment-896396763
> this LGTM. > Why did we change `with_context` to `with_filename`? Maybe context could return an object with further context? (e.g. partition, line name, etc) `_ReadRange` currently only contains the `FileMetadata` of the object and the `OffsetRange`. `FileMetadata` has the filename and the size, but I don't fully see the use of adding the size as an output, since you'd probably can get the same using `ReadableFiles` without the need of outputting row by row and then aggregating. LMKWYT. The other things you mention would be helpful, but (afaik) not possible with the current implementation of `_ReadRange`. Maybe a future PR? Thanks for having a look, Pablo! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
