anthonyqzhu commented on a change in pull request #15214:
URL: https://github.com/apache/beam/pull/15214#discussion_r687024979
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -491,14 +514,27 @@ private BundleProcessor createBundleProcessor(
}
}
- // Instantiate a State API call handler depending on whether a State
ApiServiceDescriptor
- // was specified.
- HandleStateCallsForBundle beamFnStateClient =
- bundleDescriptor.hasStateApiServiceDescriptor()
- ? new BlockTillStateCallsFinish(
- beamFnStateGrpcClientCache.forApiServiceDescriptor(
- bundleDescriptor.getStateApiServiceDescriptor()))
- : new FailAllStateCallsForBundle(processBundleRequest);
+ // Instantiate a State API call handler depending on whether a State
ApiServiceDescriptor was
+ // specified.
+ HandleStateCallsForBundle beamFnStateClient;
+ if (bundleDescriptor.hasStateApiServiceDescriptor()) {
Review comment:
We merged this assuming it was okay after seeing the passing tests / TAP
presubmit passing as well.
I can introduce an experiment in front of this block today if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
