reuvenlax commented on a change in pull request #15327:
URL: https://github.com/apache/beam/pull/15327#discussion_r688157549
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java
##########
@@ -106,6 +106,7 @@
private static final ByteBuddy BYTE_BUDDY = new ByteBuddy();
private static final BitSetCoder NULL_LIST_CODER = BitSetCoder.of();
private static final VarIntCoder VAR_INT_CODER = VarIntCoder.of();
+ private static final BitSet EMPTY_BIT_SET = new BitSet(0);
Review comment:
I believe this is correct because BitSet.get(n) always returns false if
n >= size. Please add a comment explaining this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
