youngoli commented on a change in pull request #15323: URL: https://github.com/apache/beam/pull/15323#discussion_r688211042
########## File path: sdks/go/pkg/beam/model/PROTOBUF.md ########## @@ -24,44 +24,38 @@ If you make changes to .proto files, you will need to rebuild the generated Go c First, follow this one-time setup: 1. Download [the protobuf compiler](https://github.com/google/protobuf/releases). - The simplest approach is to download one of the prebuilt binaries and extract - it somewhere in your machine's `$PATH`. -1. A properly installed Go development environment per [the official - instructions](https://golang.org/doc/install). `$GOPATH` must be set properly. - If it's not set, follow - [these instructions](https://github.com/golang/go/wiki/SettingGOPATH). + The simplest approach is to download one of the prebuilt binaries (named + `protoc`) and extract it somewhere in your machine's `$PATH`. 1. Add `$GOBIN` to your `$PATH`. (Note: If `$GOBIN` is not set, add `$GOPATH/bin` instead.) To generate the code: 1. Navigate to this directory (`pkg/beam/model`). -1. `go get -u github.com/golang/protobuf/protoc-gen-go` +1. `go install google.golang.org/protobuf/cmd/protoc-gen-go@latest` +1. `go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest` Review comment: Done. This also let me shorten the instructions by a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
