ihji commented on a change in pull request #15307:
URL: https://github.com/apache/beam/pull/15307#discussion_r689682848
##########
File path: release/src/main/scripts/run_rc_validation.sh
##########
@@ -168,8 +184,7 @@ bq version
echo "-----------------Checking gnome-terminal-----------------"
if [[ -z `which gnome-terminal` ]]; then
echo "You don't have gnome-terminal installed."
- if [[ "$INSTALL_GNOME_TERMINAL" != true ]]; then
- sudo apt-get upgrade
+ if [[ "$INSTALL_GNOME_TERMINAL" = true ]]; then
Review comment:
I believe so. The software needs to be installed when the variable is
true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
