kmjung commented on a change in pull request #15185:
URL: https://github.com/apache/beam/pull/15185#discussion_r689699192



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1841,15 +2118,29 @@ class ReadFromBigQuery(PTransform):
     on GCS, and then reads from each produced file. File format is Avro by
     default.
 
+  .. warning::
+      DATETIME columns are parsed as strings in the fastavro library. As a
+      result, such columns will be converted to Python strings instead of 
native
+      Python DATETIME types.
+
   Args:
+    method: The method to use to read from BigQuery. It may be EXPORT or
+      DIRECT_READ. EXPORT invokes a BigQuery export request
+      (https://cloud.google.com/bigquery/docs/exporting-data). DIRECT_READ 
reads
+      directly from BigQuery storage using the BigQuery Read API
+      (https://cloud.google.com/bigquery/docs/reference/storage). If
+      unspecified, the default is currently EXPORT.
+    use_fastavro (bool): If method is `DIRECT_READ` and :data:`True`, the

Review comment:
       I don't know that we'll be able to combine the Avro and storage API 
stream sources -- I was expecting that we could remove support for the 
non-fastavro path from both at the same time, though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to