benWize commented on a change in pull request #15328:
URL: https://github.com/apache/beam/pull/15328#discussion_r689741424
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
##########
@@ -395,17 +416,34 @@ def write_mutations(self, throttler, rpc_stats_callback,
throttle_delay=1):
for element in self._batch_elements:
self.add_to_batch(element)
+ # Create request count metric
+ resource = resource_identifiers.DatastoreNamespace(self._project, None)
+ labels = {
+ monitoring_infos.SERVICE_LABEL: 'Datastore',
+ monitoring_infos.METHOD_LABEL: 'BatchDatastoreWrite',
+ monitoring_infos.RESOURCE_LABEL: resource,
+ monitoring_infos.DATASTORE_NAMESPACE_LABEL: None,
+ monitoring_infos.DATASTORE_PROJECT_ID_LABEL: self._project,
+ monitoring_infos.STATUS_LABEL: 'ok'
+ }
+
+ service_call_metric = ServiceCallMetric(
+ request_count_urn=monitoring_infos.API_REQUEST_COUNT_URN,
+ base_labels=labels)
+
try:
start_time = time.time()
self._batch.commit()
end_time = time.time()
+ service_call_metric.call('ok')
rpc_stats_callback(successes=1)
throttler.successful_request(start_time * 1000)
commit_time_ms = int((end_time - start_time) * 1000)
return commit_time_ms
- except Exception:
+ except Exception as e:
self._batch = None
+ service_call_metric.call(e.code)
Review comment:
Change done! I was able to run the integration test to catch and log the
exception
<img width="517" alt="Screen Shot 2021-08-16 at 11 25 20"
src="https://user-images.githubusercontent.com/74670721/129607652-79acb0f4-33d1-4a41-816f-51e43cc0e458.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/74670721/129607652-79acb0f4-33d1-4a41-816f-51e43cc0e458.png"](https://user-images.githubusercontent.com/74670721/129607652-79acb0f4-33d1-4a41-816f-51e43cc0e458.png"){kind=link}