MiguelAnzoWizeline commented on a change in pull request #15183:
URL: https://github.com/apache/beam/pull/15183#discussion_r689901411
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
##########
@@ -901,12 +907,28 @@ private RunQueryResponse
runQueryWithRetries(RunQueryRequest request) throws Exc
Sleeper sleeper = Sleeper.DEFAULT;
BackOff backoff = RUNQUERY_BACKOFF.backoff();
while (true) {
+ HashMap<String, String> baseLabels = new HashMap<>();
+ baseLabels.put(MonitoringInfoConstants.Labels.PTRANSFORM, "TODO");
+ baseLabels.put(MonitoringInfoConstants.Labels.SERVICE, "Datastore");
+ baseLabels.put(MonitoringInfoConstants.Labels.METHOD,
"runQueryWithRetries");
+ baseLabels.put(MonitoringInfoConstants.Labels.RESOURCE, "TODO");
+ baseLabels.put(
+ MonitoringInfoConstants.Labels.BIGQUERY_PROJECT_ID,
request.getProjectId());
+ ServiceCallMetric serviceCallMetric =
+ new
ServiceCallMetric(MonitoringInfoConstants.Urns.API_REQUEST_COUNT, baseLabels);
try {
RunQueryResponse response = datastore.runQuery(request);
+ serviceCallMetric.call("ok");
rpcSuccesses.inc();
return response;
} catch (DatastoreException exception) {
rpcErrors.inc();
+ GoogleJsonError.ErrorInfo errorInfo = getErrorInfo(exception);
+ if (errorInfo == null) {
+
serviceCallMetric.call(ServiceCallMetric.CANONICAL_STATUS_UNKNOWN);
+ throw exception;
+ }
+ serviceCallMetric.call(errorInfo.getReason());
Review comment:
Hi, I followed up in the dev list mail. I'm modifying the select query
with non existent tables and fields, and the sql parser is throwing an
exception before going to the Datastore reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
