MiguelAnzoWizeline commented on pull request #15342: URL: https://github.com/apache/beam/pull/15342#issuecomment-900694560
@ajamato Hi, I started to work also in this metric but I have a question, I’m not sure what an acceptable error case metric would be in the [read](https://github.com/apache/beam/blob/68457fbaf9000c6b75972ebb588cc05116e0195d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L160) method, would it be needed to add a try catch to check for exceptions in [advance()](https://github.com/apache/beam/blob/68457fbaf9000c6b75972ebb588cc05116e0195d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L166) and log and re-throw? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
