kw2542 commented on a change in pull request #15322:
URL: https://github.com/apache/beam/pull/15322#discussion_r690538539



##########
File path: 
sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
##########
@@ -329,7 +329,11 @@ public void testWithRunnerDeterminedShardingUnbounded() 
throws IOException {
   }
 
   @Test
-  @Category({NeedsRunner.class, UsesUnboundedPCollections.class, 
UsesTestStream.class})
+  @Category({
+    NeedsRunner.class,
+    UsesUnboundedPCollections.class,
+    UsesTestStreamWithProcessingTime.class

Review comment:
       Updated

##########
File path: 
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4670,7 +4670,7 @@ public void onTimer(
     }
 
     @Test
-    @Category(NeedsRunner.class)
+    @Category({NeedsRunner.class, UsesTimersInParDo.class, 
UsesTestStream.class})

Review comment:
       Updated all tests with `UsesTestStreamWithProcessingTime` to have 
`UsesTestStream` for now.

##########
File path: 
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4670,7 +4670,7 @@ public void onTimer(
     }
 
     @Test
-    @Category(NeedsRunner.class)
+    @Category({NeedsRunner.class, UsesTimersInParDo.class, 
UsesTestStream.class})

Review comment:
       I have updated the PR so that tests with 
`UsesTestStreamWithProcessingTime` are also annotated with `UsesTestStream`, 
does this look good to you?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to