lukecwik commented on pull request #15338:
URL: https://github.com/apache/beam/pull/15338#issuecomment-902131179


   > > I don't see any logic around `@JsonSerialize/@JsonIgnore` as we 
discussed.
   > 
   > ~I'm not sure what I'd be testing/adding logic for here? The places that 
serialize PipelineOptions I've seen pass the typed PipelineOptions object to an 
ObjectMapper directly, is there some other path you were thinking about?~
   > 
   > never mind I see what you mean now, I didn't realize the PipelineOptions 
had a custom serializer/deserializer as well. Will update that.
   
   Great, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to