zhoufek commented on a change in pull request #15340:
URL: https://github.com/apache/beam/pull/15340#discussion_r692934388
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2332,22 +2332,19 @@ def expand(self, pcoll):
unsafe_reason = trigger.may_lose_data(windowing)
if unsafe_reason != DataLossReason.NO_POTENTIAL_LOSS:
+ reason_msg = str(unsafe_reason).replace('DataLossReason.', '')
if pcoll.pipeline.allow_unsafe_triggers:
Review comment:
`options` is marked as deprecated with the message, "References to
\<pipeline\>.options will not be supported."
For that reason, I added a property to access the option:
https://github.com/apache/beam/blob/b0e9f2638cbaca822ee6a58bd8ec0e61db8e799e/sdks/python/apache_beam/pipeline.py#L243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
