lostluck commented on a change in pull request #15364:
URL: https://github.com/apache/beam/pull/15364#discussion_r694210423
##########
File path: sdks/go/pkg/beam/runners/direct/direct.go
##########
@@ -74,10 +74,27 @@ func Execute(ctx context.Context, p *beam.Pipeline)
(beam.PipelineResult, error)
if err = plan.Down(ctx); err != nil {
return nil, err
}
- // TODO(lostluck) 2020/01/24: What's the right way to expose the
- // metrics store for the direct runner?
- metrics.DumpToLog(ctx)
- return nil, nil
+
+ prResult, prerr := newDirectPipelineResult(ctx)
+ return prResult, prerr
Review comment:
This should be able to inlined with the return.
```suggestion
return newDirectPipelineResult(ctx)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
