lukecwik commented on a change in pull request #14811:
URL: https://github.com/apache/beam/pull/14811#discussion_r697626098
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java
##########
@@ -73,18 +74,18 @@ public static BatchSpannerRead create(
.apply(
"Generate Partitions",
ParDo.of(new GeneratePartitionsFn(getSpannerConfig(),
txView)).withSideInputs(txView))
- .apply("Shuffle partitions", Reshuffle.<Partition>viaRandomKey())
.apply(
"Read from Partitions",
ParDo.of(new ReadFromPartitionFn(getSpannerConfig(),
txView)).withSideInputs(txView));
}
+ // TODO (BEAM-12551) When @InitialRestriction and @SplitRestriction are able
to access sideInputs
Review comment:
```suggestion
// TODO (BEAM-12522) When @InitialRestriction and @SplitRestriction are
able to access sideInputs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
