mxm commented on a change in pull request #14671:
URL: https://github.com/apache/beam/pull/14671#discussion_r698359502
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -319,25 +319,9 @@ def _service(self):
if isinstance(self._expansion_service, str):
channel_options = [("grpc.max_receive_message_length", -1),
("grpc.max_send_message_length", -1)]
- if hasattr(grpc, 'local_channel_credentials'):
- # Some environments may not support insecure channels. Hence use a
- # secure channel with local credentials here.
Review comment:
There are two problems here:
1. The issue the MR is trying to solve, i.e. allowing for remote connections
2. The problem of insecure channels not being supported in all environments
(possible regression caused by this MR)
When fixing a bug we must ensure not to add another bug. This is my only
concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
