apilloud commented on a change in pull request #14729:
URL: https://github.com/apache/beam/pull/14729#discussion_r698810897
##########
File path: sdks/java/extensions/sql/src/main/codegen/includes/parserImpls.ftl
##########
@@ -146,10 +146,10 @@ Schema.Field Field() :
* ( LOCATION location_string )?
* ( TBLPROPERTIES tbl_properties )?
*/
-SqlCreate SqlCreateExternalTable() :
+SqlCreate SqlCreateExternalTable(Span s, boolean replace) :
{
- final Span s = Span.of();
- final boolean replace = false;
+<#-- final Span s = Span.of();-->
Review comment:
Done.
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamTableStatistics.java
##########
@@ -76,6 +77,11 @@ public boolean isKey(ImmutableBitSet columns) {
return false;
}
+ @Override
+ public List<ImmutableBitSet> getKeys() {
+ return Collections.emptyList(); // FIXME BEAM-9379: Is this correct???
Review comment:
That looks correct, we don't have keys in the traditional database sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
