scwhittle commented on a change in pull request #15420:
URL: https://github.com/apache/beam/pull/15420#discussion_r698700733
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -898,6 +896,7 @@ public void deleteDataset(String projectId, String
datasetId)
BackOffAdapter.toGcpBackOff(rateLimitBackoffFactory.backoff());
long totalBackoffMillis = 0L;
while (true) {
+ ServiceCallMetric serviceCallMetric =
BigQueryUtils.writeCallMetric(ref);
Review comment:
seems like it could be lifted out of while loop
but at a higher level it seemed like the ServiceCallMetric had some caching,
would it be better to just add synchronization so that it still can be used
across more calls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
