tvalentyn commented on a change in pull request #15004:
URL: https://github.com/apache/beam/pull/15004#discussion_r699590704
##########
File path: sdks/python/apache_beam/internal/gcp/auth.py
##########
@@ -115,29 +131,32 @@ def get_service_credentials(cls):
@staticmethod
def _get_service_credentials():
- if is_running_in_gce:
- # We are currently running as a GCE taskrunner worker.
- return _GceAssertionCredentials(user_agent='beam-python-sdk/1.0')
Review comment:
I think this path was used to authenticate requests originating from GCE
VMs, and we had it so that when Beam SDK is running Dataflow workers, the
requests to GCP were authenticated just because the SDK is running on GCE VM.
I wonder how this will work with the new dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
