lukecwik commented on pull request #15338:
URL: https://github.com/apache/beam/pull/15338#issuecomment-910524439
> I think the patch is actually really simple, I can get another PR going
right now, or we can revert and re-apply with it fixed. I'm fine with either.
>
> ```
> diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
> index 030c56ba59..e20a8641b6 100644
> ---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
> +++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
> @@ -44,6 +44,7 @@ import
com.fasterxml.jackson.databind.node.TreeTraversingParser;
> import com.fasterxml.jackson.databind.ser.DefaultSerializerProvider;
> import com.fasterxml.jackson.databind.type.TypeBindings;
> import com.fasterxml.jackson.databind.util.SimpleBeanPropertyDefinition;
> +import com.fasterxml.jackson.databind.util.TokenBuffer;
> import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
> import java.beans.BeanInfo;
> import java.beans.IntrospectionException;
> @@ -499,7 +500,8 @@ public class PipelineOptionsFactory {
>
> private static final DefaultDeserializationContext
DESERIALIZATION_CONTEXT =
> new
DefaultDeserializationContext.Impl(MAPPER.getDeserializationContext().getFactory())
> - .createInstance(MAPPER.getDeserializationConfig(), null, null);
> + .createInstance(
> + MAPPER.getDeserializationConfig(), new TokenBuffer(MAPPER,
false).asParser(), null);
> ```
You can get both PRs out (forward fix and rollback) and run the additional
failing tests in the forward fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
