aromanenko-dev commented on pull request #14927: URL: https://github.com/apache/beam/pull/14927#issuecomment-911606245
Thanks, I'm fine with code changes. LGTM. However, before merging, please, squash all commits and avoid the `merge` commits - please, use `rebase` instead. Also, it's not a good practice to create a PR from `master` branch, it's much better to use a dedicated feature branch for that. Though, I think we can stand with this for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
