ihji commented on a change in pull request #15094:
URL: https://github.com/apache/beam/pull/15094#discussion_r704908661
##########
File path: sdks/go/test/build.gradle
##########
@@ -166,3 +174,33 @@ task ulrValidatesRunner {
}
}
}
+
+// A method for configuring a cross-language validates runner test task,
+// intended to be used in calls to createCrossLanguageValidatesRunnerTask.
+ext.goIoValidatesRunnerTask = { proj, name, scriptOpts ->
+ return proj.tasks.create(name: name) {
+ group = "Verification"
+
+ dependsOn ":sdks:go:test:goBuild"
+ dependsOn ":sdks:go:container:docker"
+ dependsOn ":sdks:java:container:java11:docker"
+ dependsOn
":sdks:java:testing:expansion-service:buildTestExpansionServiceJar"
+ dependsOn ":sdks:java:io:expansion-service:build"
Review comment:
Does `:build` also create `jar`? Do we need `:shadowJar`?
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -359,7 +360,16 @@ createCrossLanguageValidatesRunnerTask(
"--numprocesses=8",
"--timeout=4500",
"--log-cli-level=INFO",
- ]
+ ],
+ goScriptOptions: [
+ "--runner dataflow",
+ "--project ${dataflowProject}",
+ "--dataflow_project ${dataflowProject}",
+ "--region ${dataflowRegion}",
+ "--tests \"./test/integration/xlang\"",
+ "--dataflow_worker_jar
${project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath}",
Review comment:
Do we need this? I think Dataflow worker jar is already included in Java
SDK harness container.
##########
File path: sdks/go/test/integration/io/xlang/kafka/jar.go
##########
@@ -13,13 +13,18 @@
// See the License for the specific language governing permissions and
// limitations under the License.
+// Exclude OSes which do not support the timeout command or syscall.SIGTERM.
Review comment:
`timeout` is not available by default on Mac too. Can we check whether
`timeout` is installed before `exec.Command` and halt gracefully if not? Or
implement the timeout feature programmatically?
##########
File path: sdks/go/test/build.gradle
##########
@@ -166,3 +174,33 @@ task ulrValidatesRunner {
}
}
}
+
+// A method for configuring a cross-language validates runner test task,
+// intended to be used in calls to createCrossLanguageValidatesRunnerTask.
+ext.goIoValidatesRunnerTask = { proj, name, scriptOpts ->
+ return proj.tasks.create(name: name) {
+ group = "Verification"
+
+ dependsOn ":sdks:go:test:goBuild"
+ dependsOn ":sdks:go:container:docker"
+ dependsOn ":sdks:java:container:java11:docker"
Review comment:
This is not necessary. `setupTask` depends on Java container build and
`goIoValidatesRunnerTask` depends on `setupTask`.
##########
File path: sdks/go/test/build.gradle
##########
@@ -166,3 +174,33 @@ task ulrValidatesRunner {
}
}
}
+
+// A method for configuring a cross-language validates runner test task,
+// intended to be used in calls to createCrossLanguageValidatesRunnerTask.
+ext.goIoValidatesRunnerTask = { proj, name, scriptOpts ->
+ return proj.tasks.create(name: name) {
+ group = "Verification"
+
+ dependsOn ":sdks:go:test:goBuild"
+ dependsOn ":sdks:go:container:docker"
+ dependsOn ":sdks:java:container:java11:docker"
+ dependsOn
":sdks:java:testing:expansion-service:buildTestExpansionServiceJar"
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
