robertwb commented on pull request #15476: URL: https://github.com/apache/beam/pull/15476#issuecomment-916401900
I'm a little wary of this change. Currently, there's ambiguity as to what we should do if a transform and its surrounding composite both declare a (non-trivial) type constraint on an output PCollection. Previously, the inner transform would win, but this changes it to let the outer transform win. That might fix this test, but might break others. One option is to actually address the TODO here and implement (best-effort?) intersection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
