roger-mike commented on a change in pull request #15294:
URL: https://github.com/apache/beam/pull/15294#discussion_r705996696
##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py
##########
@@ -284,6 +288,8 @@ class
_BeamSpannerConfiguration(namedtuple("_BeamSpannerConfiguration",
["project",
"instance",
"database",
+ "table",
Review comment:
I think this is consistent with the parameters in this namedtuple~
otherwise, there would be ```project_id``` and ```instance_id```,
```database_id```, etc. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]