benWize commented on pull request #15493: URL: https://github.com/apache/beam/pull/15493#issuecomment-917095479
@ajamato Would you help me to review the progress on this? It is still pending to add `queryName` as label metrics, but I want to ask your opinion about it. I added `queryName` to `ReadOperation` Builder https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/ReadOperation.java#L99 but at this point the `ReadOperation` is not accessible, only `Transaction` https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java#L161 My suggested approach is to add queryName to `CreateTransaction` Builder so I can extract queryName inside `ReadFromPartitionFn` process method https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java#L753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
