robertwb commented on pull request #15458: URL: https://github.com/apache/beam/pull/15458#issuecomment-917307509
On Fri, Sep 10, 2021 at 5:48 PM Yifan Mai ***@***.***> wrote: > Could you explain the meaning of "Avoid apiary submission"? My > understanding from this code is that this change will now cause the graph > JSON to be uploaded here > <https://github.com/apache/beam/blob/25c67cdbae3ed2b9158d1f18ff4d522422dd3886/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L671-L683> > when it previously would not have been, if we are using unified worker, > use_portable_job_submission is set, and upload_graph is unset. > The (potentially large) graph will not be uploaded via apiary, but instead uploaded to GCS. (Eventually we could remove this as well, but keeping it for now just in case.) > Relatedly, I recently noticed that setting upload_graph causes the graph > optimizer to stop running; will this PR change this behavior? > No. That sounds concerning, do you have more details? > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/15458#issuecomment-917306786>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADWVAP3RNFNBFQUL4ROFSTUBKRNFANCNFSM5DMURF6A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
