KevinGG commented on a change in pull request #15490:
URL: https://github.com/apache/beam/pull/15490#discussion_r707626254
##########
File path: sdks/python/apache_beam/runners/interactive/display/pipeline_graph.py
##########
@@ -182,8 +182,8 @@ def _generate_graph_dicts(self):
for pcoll_id in transform.outputs.values():
pcoll_node = None
if self._pipeline_instrument:
- pcoll_node = self._pipeline_instrument.cacheable_var_by_pcoll_id(
- pcoll_id)
+ cacheable = self._pipeline_instrument._cacheables.get(pcoll_id)
Review comment:
We can expose the cacheables as the property of a PipelineInstrument.
I removed the property because I don't want PipelineInstrument to be abused
by other modules. In most cases, we should directly get cacheables through the
utility/inspector, not through building a PipelineInstrument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
