tvalentyn commented on a change in pull request #15507:
URL: https://github.com/apache/beam/pull/15507#discussion_r708732215
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -497,9 +496,8 @@ def input_elements(
raise RuntimeError('Channel closed prematurely.')
if abort_callback():
return
- t, v, tb = self._exc_info
- if t:
- raise t(v).with_traceback(tb)
+ if self._exception:
+ raise self._exception
Review comment:
see: https://stackoverflow.com/a/18188660/5153670
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -497,9 +496,8 @@ def input_elements(
raise RuntimeError('Channel closed prematurely.')
if abort_callback():
return
- t, v, tb = self._exc_info
- if t:
- raise t(v).with_traceback(tb)
+ if self._exception:
+ raise self._exception
Review comment:
given that this is within `except queue.Empty`, i think we may want to
`raise self._exception from None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
