hmc-cs-mdrissi commented on a change in pull request #15415:
URL: https://github.com/apache/beam/pull/15415#discussion_r708739380



##########
File path: sdks/python/apache_beam/utils/proto_utils.py
##########
@@ -40,13 +40,13 @@
 @overload
 def pack_Any(msg):
   # type: (message.Message) -> any_pb2.Any
-  pass
+  ...

Review comment:
       The pb2.py is not type checked, but pb2.pyi is needed for type 
inference. Looks like proto file has a comment that confuses mypy. I can make a 
tweak to the comment to make it fine for mypy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to